Add invitation to open issues #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an invitation to open issues to the regexp summary doc Signed-off-by: Daniel Appelquist <[email protected]>
ctcpip
approved these changes
Jun 4, 2024
Co-authored-by: Chris de Almeida <[email protected]> Signed-off-by: Daniel Appelquist <[email protected]>
|
Hi @torgo! Are you still interested in getting this in? I support the idea but would ask for incorporating @david-a-wheeler's suggestion. |
torgo
commented
Dec 17, 2024
Signed-off-by: Daniel Appelquist <[email protected]>
|
Amended to reflect @david-a-wheeler's request. On that basis, and the basis of our discussion in today's call, I think this can be merged. |
Signed-off-by: David A. Wheeler <[email protected]>
|
Looks great, but we had a merge conflict. I fixed it in the way I think it was intended. |
|
@torgo thanks so much! Let's just merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an invitation to open issues to the regexp summary doc